Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql: Fix ColumnNumber() panic with nil Resultset #968

Merged
merged 4 commits into from
Jan 10, 2025
Merged

mysql: Fix ColumnNumber() panic with nil Resultset #968

merged 4 commits into from
Jan 10, 2025

Conversation

dveeden
Copy link
Collaborator

@dveeden dveeden commented Jan 10, 2025 •
edited by lance6716
Loading

No description provided.

@dveeden dveeden mentioned this pull request Jan 10, 2025
Closed
lance6716
lance6716 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely correct, so I'm going to merge it. However I can't understand if #964 has the same root cause, so I remove the "Closes #964" in PR description

@lance6716 lance6716 merged commit 7108b1d into go-mysql-org:master Jan 10, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@atercattus atercattus Awaiting requested review from atercattus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dveeden @lance6716